feat(lambda-at-edge): support custom redirects #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphang
commented
Sep 26, 2020
| import { compileDestination, matchPath } from "./matcher"; | ||
| import { RedirectData, RoutesManifest } from "../../types"; | ||
| import * as http from "http"; | ||
|
|
There was a problem hiding this comment.
Now that we have Rollup, we can make the component more maintainable by using different files - it will all get bundled/optimized into the handler JS files. Not sure what's a good name, let me know if you have thoughts on this (I put the in routing/ for now.
There was a problem hiding this comment.
I think routing/ makes sense. On a related note, would be nice if at some point we refactored all routing concerns into a router, similar to what the next-server impl does
danielcondemarin
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of #587. Summary:
path-to-regexpfor custom redirects (same one as Next.js uses). Some of this can also be reused for custom rewrites and headers.next.config.js. Custom redirects are matched one-by-one from the provided redirects inroutes-manifestand the first matching redirect is returned. The default trailing slash redirects are ignored for now (by removing them at build time) as they are already handled in a non-regex solution. I also need to put the redirect logic near thedefault-handlerstart right after trailing slash redirect, as redirects can overwrite an existing source page (same behavior in Vercel).path-to-regexpuses RegExp underneath which should be quite performant. I would only expect there to be performance issues if users have really long lists of redirects and/or are using complex paths. For the majority of users, this shouldn't be the case - and the default trailing slash redirects are anyway handled without regex.Note: big PR but a lot of it is updating the tests to have good coverage.
Testing
Added lots of test coverage via unit tests, integration tests, and e2e tests.
Note: there is no e2e test with base path and trailingSlash = true, although I have locally tested it and unit/integration tests should cover it. I will add in a future PR as part of larger work for more e2e tests.
If anyone can pull this branch and test this and/or suggest other test cases I may have missed, that will be really helpful. I think I covered most of them. Thanks!