Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different stroke on each node #48

Closed
aurbano opened this issue Jan 29, 2018 · 3 comments
Closed

Different stroke on each node #48

aurbano opened this issue Jan 29, 2018 · 3 comments

Comments

@aurbano
Copy link

aurbano commented Jan 29, 2018

It would be nice to be able to set the stroke color per node, in a similar way to the fill color:

Current fill color code:

let fill = node.color || config.node.color;

Current storke color code:

let stroke = config.node.strokeColor;

I'd send you a PR to this but I'm not sure if you want to handle it differently

let stroke = node.strokeColor || config.node.strokeColor;
@danielcaldas
Copy link
Owner

@aurbano that should be the way to handle it, a similar approach to what is done in node color prop. If you could open a PR with this would be awesome 👌

@stale
Copy link

stale bot commented Feb 28, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 28, 2018
@stale stale bot closed this as completed Mar 10, 2018
@danielcaldas
Copy link
Owner

Duplicate of #71 and closed with PR #79

@danielcaldas danielcaldas added the duplicate already reported label Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants