-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warning C4002 on windows with msvs2022 #352
Comments
You're right, I guess we haven't had a user with 47+ parameters before, nor a test case with that many parameters. Thanks for reporting this. Would you consider submitting a pull request with this change? (makes it easier to credit the contribution) |
I have submmited a pull request. Happy to contribute. |
We should keep this open, until we have a release with the fix. Your PR is merged with master. It also looks like you've reached the limit of the number of parameters supported (50) so I've increased that limit to 70. I've also added a test case that covers the case of 70 parameters. |
Nice work!! I have extended the limit to 54 myself. |
I have tested . Everything works well. |
Fixed in 0.168.4 |
Describe the bug
my code
llvm refused to compile, it produced an error:
too many arguments for function-like macro invocation
msvs give a warning:
warning C4002: too many arguments for function-like macro invocation : JSONCONS_EXPAND_CALL5.
I checked the definition of JSONCONS_EXPAND_CALL5 (in json_traits_macros.hpp ), and I got one line seems like an error:
JSONCONS_EXPAND_CALL5(Call, P1, P2, P3, P4, 47, )
I changed it to (delete the last ","):
JSONCONS_EXPAND_CALL5(Call, P1, P2, P3, P4, 47)
everything seems ok. Both msvc and llvm compiled silently and sucssesfully.
The text was updated successfully, but these errors were encountered: