Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing return in typed_array::data(uint64_array_arg_t) const? #213

Closed
alekseyt opened this issue Feb 6, 2020 · 2 comments
Closed

Missing return in typed_array::data(uint64_array_arg_t) const? #213

alekseyt opened this issue Feb 6, 2020 · 2 comments

Comments

@alekseyt
Copy link

alekseyt commented Feb 6, 2020

It's this line: https://github.com/danielaparker/jsoncons/blob/master/include/jsoncons/staj_reader.hpp#L870

Doesn't it miss a return?

I'm not aware of any issues related to this, but i spotted this warning when cross-compiling with clang for OSX:

In file included from .../include/jsoncons/ser_traits.hpp:20:
.../include/jsoncons/staj_reader.hpp:871:5: warning: 
      control may reach end of non-void function [-Wreturn-type]
    }
    ^
.../include/jsoncons/staj_reader.hpp:1022:44: note: in
      instantiation of member function
      'jsoncons::typed_array<std::__1::allocator<char> >::data' requested here
                data_.uint64_data_ = other.data(uint64_array_arg).data();
                                           ^
@danielaparker
Copy link
Owner

Thanks for reporting this! Fixed on master.

@alekseyt
Copy link
Author

alekseyt commented Feb 7, 2020

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants