Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background colour set for Text Input but not Radios #554

Open
daniel-ac-martin opened this issue Jul 1, 2022 · 3 comments
Open

Background colour set for Text Input but not Radios #554

daniel-ac-martin opened this issue Jul 1, 2022 · 3 comments

Comments

@daniel-ac-martin
Copy link
Owner

This could be due to an old version of govuk-fontend.

Or it's something that I've done to improve the styling of <select>.

@robValtech
Copy link

@daniel-ac-martin it seems that checkboxes and radios don't have a background colour specified, but worry not it's an easy fix.

On the project we're currently using NotGovUK I just applied an override:

.govuk {
    &-radios__label,
    &-checkboxes__label {
      &::before {
        background: govuk-colour("white");
      }
    }

@robpataki
Copy link

Hi @daniel-ac-martin. Just here to say - loving your GOVUK React component library! ❤️ I would love to contribute, so I raised a PR to add background to the Radio and Checkbox components.

@daniel-ac-martin
Copy link
Owner Author

Thanks @robpataki. Contributions are very welcome.

I think with this particular issue, we need to work out the cause of the discrepancy and also compare to what GDS provide from govuk-frontend. I'll comment further on your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants