Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File size limit is not inclusive #1344

Closed
ShaneZhengNZ opened this issue Feb 11, 2016 · 1 comment
Closed

File size limit is not inclusive #1344

ShaneZhengNZ opened this issue Feb 11, 2016 · 1 comment
Labels

Comments

@ShaneZhengNZ
Copy link
Contributor

When I set the file upload size, I set to 200MB (which is in theory 209715200B), but we notice that if I upload a file with 199MB size (209715100B), it fails.

I think there are two problems:

  1. The size calculation is not using 1024, but 1000. Not very accurate.
    2: The size limit should be inclusive, i.e. if I set 200MB, I should be able to load 200MB file, but not 201MB (which is 1024_1024_210 = 210763776B).
@danialfarid
Copy link
Owner

Fixed at 12.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants