Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify URL format for commit links #11

Open
tecywiz121 opened this issue May 15, 2018 · 4 comments
Open

Specify URL format for commit links #11

tecywiz121 opened this issue May 15, 2018 · 4 comments

Comments

@tecywiz121
Copy link

This is more of a feature request, since I'm not at all familiar with elixir.

Right now it seems like opencov appends /commit/f52e1701ddef059aa549ef2c00298f30fe6e4f5a to the repository URL when it generates commit links. That works for GitHub, but not for other git browsers.

It'd be nice if we could specify a pattern in the repository configuration page for custom URLs.

@danhper
Copy link
Owner

danhper commented May 16, 2018

Hi, thanks for reporting.
Opencov currently supports github/gitlab URL format as well as bitbucket URL format.
What git hosting service are you using?
Thank you.

@tecywiz121
Copy link
Author

Bitbucket Server.

The "Browse Source" URL looks like: /project/PROJECT_ID/repos/REPOSITORY_NAME/browse
The "Commit Detail" URL looks like: /project/PROJECT_ID/repos/REPOSITORY_NAME/commits/HASH

@danhper
Copy link
Owner

danhper commented May 18, 2018

I see, thank you for the information.
The commit detail URL is currently hard-coded and looks at the project base URL, so it does not work for custom domains.
https://github.com/tuvistavie/opencov/blob/master/web/views/common_view.ex#L38

We need to add a setting to the project that would probably only be shown when the project is neither on github.com nor on bitbucket.org.
I will try to work on this, but I do not have much time right now, so help is very welcome.
If you would like to help but need more information to get started, please feel free to ask here and I will be very pleased to guide you.

@sushlala
Copy link

I ran into this too, on our enterprise bitbucket setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants