From bf5a17d9e392d4ac6af0fad661d1519ac30166e9 Mon Sep 17 00:00:00 2001 From: Gerrit User 5492 <5492@58829da1-049c-39fb-b951-ebdcd0984767> Date: Fri, 15 Jun 2018 07:47:55 +0000 Subject: [PATCH] Update patch set 15 Patch Set 15: > Patch Set 13: > > > Patch Set 13: > > > > > Patch Set 13: Code-Review+1 > > > > > > > Patch Set 13: > > > > > > > > For the options, 1) might require a lot of changes and I'm not sure if it should be part of this task. For 2) and 3), you probably have a better idea which would be the best option. > > > > > > In that case I'd lean towards just using the "increasing quality" order, since using different orders in different places would be pretty confusing and bug-prone. In that case, this LGTM, though I'd recommend documenting how simulcast config works somewhere (above RtpSenderInterface::SetParmaeters?). > > > > Chrome might have to reverse the order. I'll raise a spec bug pointing out that the order is not clear. > > Filed https://github.com/w3c/webrtc-pc/issues/1896 Is it ok to land this CL? Patch-set: 15 Reviewer: Gerrit User 5492 <5492@58829da1-049c-39fb-b951-ebdcd0984767>