Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do login into docker hub so we could reliably build our docker image #2043

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

yarikoptic
Copy link
Member

Otherwise, since limiting is done per IP and we do not know where requests would be coming from to the docker hub, we could get

    #3 [auth] library/python:pull token for registry-1.docker.io
    #3 DONE 0.0s

    #2 [internal] load metadata for docker.io/library/python:3.11-slim
    #2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/python/manifests/sha256:5501a4fe605abe24de87c2f3d6cf9fd760354416a0cad0296cf284fddcdca9e2: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
    ------
     > [internal] load metadata for docker.io/library/python:3.11-slim:
    ------
    django-public.Dockerfile:1
    --------------------
       1 | >>> FROM python:3.11-slim
       2 |     # Install system librarires for Python packages:
       3 |     # * psycopg2
    --------------------
    ERROR: failed to solve: python:3.11-slim: failed to resolve source metadata for docker.io/library/python:3.11-slim: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/python/manifests/sha256:5501a4fe605abe24de87c2f3d6cf9fd760354416a0cad0296cf284fddcdca9e2: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
    Error: Process completed with exit code 1.

For now added my "personal" read-only token.

@yarikoptic yarikoptic added the tests Add or improve existing tests label Oct 14, 2024
@yarikoptic
Copy link
Member Author

dandi-cli testing passes, so must be "working" and ready to be adopted. (playwright was addressed in another PR)

Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yarikoptic LGTM. can you rebase on master? I think that should fix the failing CI here.

@yarikoptic
Copy link
Member Author

yes, current failure is unrelated and fixed elsewhere. I can keep planet warmer and will rebase to get it green ;-)

Otherwise, since limiting is done per IP and we do not know where requests
would be coming from to the docker hub, we could get

    #3 [auth] library/python:pull token for registry-1.docker.io
    #3 DONE 0.0s

    #2 [internal] load metadata for docker.io/library/python:3.11-slim
    #2 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/python/manifests/sha256:5501a4fe605abe24de87c2f3d6cf9fd760354416a0cad0296cf284fddcdca9e2: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
    ------
     > [internal] load metadata for docker.io/library/python:3.11-slim:
    ------
    django-public.Dockerfile:1
    --------------------
       1 | >>> FROM python:3.11-slim
       2 |     # Install system librarires for Python packages:
       3 |     # * psycopg2
    --------------------
    ERROR: failed to solve: python:3.11-slim: failed to resolve source metadata for docker.io/library/python:3.11-slim: failed to copy: httpReadSeeker: failed open: unexpected status code https://registry-1.docker.io/v2/library/python/manifests/sha256:5501a4fe605abe24de87c2f3d6cf9fd760354416a0cad0296cf284fddcdca9e2: 429 Too Many Requests - Server message: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
    Error: Process completed with exit code 1.
@mvandenburgh mvandenburgh merged commit b239530 into master Oct 15, 2024
11 checks passed
@mvandenburgh mvandenburgh deleted the bf-ci2 branch October 15, 2024 15:56
@dandibot
Copy link
Member

🚀 PR was released in v0.3.106 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants