Use Ruff for Python static analysis and formatting #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhelba
force-pushed
the
ruff
branch
4 times, most recently
from
d24f7e7
to
aa27031
Compare
brianhelba
commented
Jan 2, 2024
brianhelba
commented
Jan 2, 2024
| ] | ||
| "**/migrations/**" = [ | ||
| "N806", # Variable in function should be lowercase | ||
| "RUF012", # Mutable class attributes should be annotated with `typing.ClassVar` |
There was a problem hiding this comment.
Could be removed after upstream fix?
brianhelba
commented
Jan 2, 2024
| "RUF012", # Mutable class attributes should be annotated with `typing.ClassVar` | ||
| ] | ||
| "**/management/commands/**" = [ | ||
| "INP001", # File is part of an implicit namespace package |
There was a problem hiding this comment.
Maybe require this to be importable, so commands can be overridden.
brianhelba
commented
Jan 2, 2024
|
|
||
| [tool.ruff.format] | ||
| quote-style = "single" | ||
|
|
There was a problem hiding this comment.
brianhelba
commented
Jan 2, 2024
| @@ -14,7 +14,7 @@ class PublishConfig(AppConfig): | |||
| verbose_name = 'DANDI: Publish' | |||
|
|
|||
| @staticmethod | |||
| def _get_sentry_performance_sample_rate(*args, **kwargs) -> float: | |||
| def _get_sentry_performance_sample_rate(*args, **kwargs) -> float: # noqa: ARG004 | |||
There was a problem hiding this comment.
Maybe ignore overall.
mvandenburgh
reviewed
Jan 3, 2024
|
|
||
| # Try to fix upstream | ||
| "RUF012", # Mutable class attributes should be annotated with `typing.ClassVar` | ||
| ] |
There was a problem hiding this comment.
Suggested change
| ] | |
| "PTH119", # TODO: re-enable this when it's fixed | |
| ] |
@brianhelba we discussed this yesterday, and decided that a somewhat significant change like #1782 would be better to decouple from the Ruff work. Do you have any objections to just temporarily ignoring this rule so we can merge this PR?
This replaces the entire Flake8 / isort / Black toolchain, while adding many new checks and improving performance.
mvandenburgh
approved these changes
Jan 22, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the entire Flake8 / isort / Black toolchain, while adding many new checks and improving performance.
These must be merged first, for tests here to pass:
assertdetected #1783