Avoid instantiating classes in swagger_auto_schema
when possible
#1608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discovered last week while discussing #1598, serializer classes used in the
swagger_auto_schema
decorator don't need to be instantiated; just passing the class itself is sufficient. Instantiating the class causes the__init__
constructor to be called, which in most cases has no negative impact, but has the potential to lead to strange bugs like we saw with the search serializer.