Pin django-minio-storage
#1597
Merged
Pin django-minio-storage
#1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandenburgh
force-pushed
the
update-minio-import
branch
from
a4bcef7
to
9b11861
Compare
|
cc @brianhelba |
danlamanna
approved these changes
May 22, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploys are currently failing https://github.com/dandi/dandi-archive/actions/runs/5047436699, due to a breaking change in the
miniopython library (this commit, for reference)I explained the issue behind this in the code comment, but to summarize:
django_s3_file_field[minio]does not pindjango-minio-storage, but does pinminioto <7. https://github.com/girder/django-s3-file-field/blob/master/setup.py#L72django-minio-storage(unpinned) in our production dependencies.django_s3_file_field[minio]is a dev dependency, it's not installed in the Heroku environment, thus the pip resolver does not take into account theminio<7requirement, and thus it ends up installing the latest version ofminio.django_s3_file_field[minio]there.This PR fixes the immediate issue by simply pinning
django-minio-storageto the latest version that doesn't requireminio<7. The long term fix will require updatingdjango_s3_file_fieldto use the latestdjango-minio-storage/minio.