Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GUI linting warnings #1590

Merged
merged 1 commit into from
May 23, 2023
Merged

Fix GUI linting warnings #1590

merged 1 commit into from
May 23, 2023

Conversation

jjnesbitt
Copy link
Member

This fixes some linting warnings that have been hanging around for a while.

Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also figure out why these aren't causing CI failures. I recall seeing this before where an eslint ERROR results in a non-zero exit code, but an eslint WARNING does not.

@jjnesbitt
Copy link
Member Author

I think we should also figure out why these aren't causing CI failures. I recall seeing this before where an eslint ERROR results in a non-zero exit code, but an eslint WARNING does not.

I believe this is the reason, that they were warnings. The main reason I cared to make this change is that every time an actual error would fail CI, all of the warnings would show too, cluttering the output.

@jjnesbitt jjnesbitt merged commit 1ca9374 into master May 23, 2023
@jjnesbitt jjnesbitt deleted the fix-linting branch May 23, 2023 16:24
@dandibot
Copy link
Member

🚀 PR was released in v0.3.37 🚀

@dandibot dandibot added the released This issue/pull request has been released. label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants