Fix UserMetadata not being created if createsuperuser script is used

[mvandenburgh]

Before, we were listening to the allauth.user_signed_up signed up signal to create the UserMetadata. Howver, this doesn't work if the User is created outside of django-allauth (like when manage.py createsuperuser is used), so this changes it to use the more general User post_save signal.

Updated approach: Before, we were listening to the allauth.user_signed_up signed up signal to create the UserMetadata. This doesn't work if the User is created with the createsuperuser management command, as composed-configuration overrides that to create a user of type EmailAsUsernameProxyUser (which is a subclass of User). See kitware-resonant/django-composed-configuration#187 for more info.

(Another) updated approach: the previous approach didn't work either, so I just overrode the createsuperuser script to manually create the UserMetadata record after it runs. I used Django signals to do this, as there's no way to get the new user's info from the Command object.

Fixes #1085

[mvandenburgh]

There seems to be a better way to do this without using signals - I'll close this and open a new PR

[mvandenburgh]

There seems to be a better way to do this without using signals - I'll close this and open a new PR

I'm not sure what "better way" I was thinking about here, but this issue still occurs in dev environments. Unless I'm missing something, signals seems like the way to do this?

[mvandenburgh]

I'm working on fixing the failing tests.

[jjnesbitt]

After testing this locally, it doesn't seem the post_save signal is actually dispatched when the createsuperuser command is used.

[mvandenburgh]

After testing this locally, it doesn't seem the post_save signal is actually dispatched when the createsuperuser command is used.

Oh, maybe that was why I closed this before 😄
I was testing with the UI, I didn't notice that one of the motivations was to make it work with createsuperuser as well. Sorry for the confusion

[waxlamp]

Can we do something super dumb, like include another management command to run after createsuperuser that patches up the new superuser with the required stuff?

[mvandenburgh]

I attempted to fix this with 6b5b6e4, but it's throwing some error during tests. I think ultimately this is something we need to fix upstream in composed-configuration.

[dandibot]

🚀 PR was released in v0.3.77 🚀