Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset's access/status is dandi:OpenAccess even though it is uploaded to an embargoed Dandiset #1997

Closed
kabilar opened this issue Aug 7, 2024 · 5 comments · Fixed by #2010
Assignees
Labels
bug Something isn't working embargo Issues around embargo functionality released This issue/pull request has been released.

Comments

@kabilar
Copy link
Member

kabilar commented Aug 7, 2024

Hi team, I recently created an embargoed Dandiset (001089) and uploaded some assets. When I look at the Asset metadata, the access/status key is set to dandi:OpenAccess. This is not a blocker, but I wanted to make sure that this is the desired behavior.

Below is the entire metadata for a simple asset (dataset_description.json) that is apart of this embargoed Dandiset.

HTTP 200 OK
Allow: GET, PUT, DELETE, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "access": [
        {
            "status": "dandi:OpenAccess",
            "schemaKey": "AccessRequirements"
        }
    ],
    "schemaKey": "Asset",
    "dateModified": "2024-08-07T16:36:55.757493-05:00",
    "schemaVersion": "0.6.8",
    "encodingFormat": "application/json",
    "wasGeneratedBy": [
        {
            "id": "urn:uuid:5e169c27-abeb-4697-b78f-0b126421af38",
            "name": "Metadata generation",
            "endDate": "2024-08-07T16:36:55.757472-05:00",
            "schemaKey": "Activity",
            "startDate": "2024-08-07T16:36:55.757472-05:00",
            "description": "Metadata generated by DANDI cli",
            "wasAssociatedWith": [
                {
                    "url": "https://github.com/dandi/dandi-cli",
                    "name": "DANDI Command Line Interface",
                    "version": "0.62.4+17.g9ae6128",
                    "schemaKey": "Software",
                    "identifier": "RRID:SCR_019009"
                }
            ]
        }
    ],
    "blobDateModified": "2024-08-07T16:35:07.344006-05:00",
    "id": "dandiasset:c39a9d1d-efe2-4574-8bed-1564f44abf5b",
    "path": "dataset_description.json",
    "identifier": "c39a9d1d-efe2-4574-8bed-1564f44abf5b",
    "contentUrl": [
        "https://api.dandiarchive.org/api/assets/c39a9d1d-efe2-4574-8bed-1564f44abf5b/download/",
        "https://dandiarchive.s3.amazonaws.com/blobs/3fd/8e1/3fd8e186-73fc-494e-9da8-17f229af2f38"
    ],
    "contentSize": 332,
    "digest": {
        "dandi:dandi-etag": "8f4fdbbf7e606861d31e638f10e4caef-1",
        "dandi:sha2-256": "8db7c6e61fb3a24d4c168e091f66e4d8b40961b45a635d48c2cac4d8087f80d1"
    },
    "@context": "https://raw.githubusercontent.com/dandi/schema/master/releases/0.6.8/context.json"
}

Thank you.

@jjnesbitt
Copy link
Member

Hi Kabi, thanks for pointing this out. This is in fact a bug in our metadata population. However, the asset isn't actually open access, it's just the metadata that's incorrect. I can work on addressing this.

@jjnesbitt jjnesbitt self-assigned this Aug 20, 2024
@kabilar
Copy link
Member Author

kabilar commented Aug 20, 2024

Thank you, Jake.

@waxlamp waxlamp added the bug Something isn't working label Aug 24, 2024
@yarikoptic yarikoptic added the embargo Issues around embargo functionality label Oct 9, 2024
@dandibot
Copy link
Member

🚀 Issue was released in v0.3.106 🚀

@dandibot dandibot added the released This issue/pull request has been released. label Oct 17, 2024
@jjnesbitt
Copy link
Member

@kabilar This has been resolved, and the asset you opened this issue with now correctly shows dandi:EmbargoedAccess.

@kabilar
Copy link
Member Author

kabilar commented Oct 18, 2024

Thank you, Jake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working embargo Issues around embargo functionality released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants