dandi:EmbargoedAccess metadata can be silently inconsistent with the actual embargo status

[yarikoptic]

https://dandiarchive.org/dandiset/000537/draft says

but I can navigate and access data files without login

so either metadata is incorrect and that is silently ok (in validation errors there is only "access: An embargo end date is required for NIH awards to be in compliance with NIH resource sharing policy.") or embargoed dandiset is publicly accessible?

edit: good candidate for yet another fsck style check

[yarikoptic]

FWIW, according to the "dandiset record" (not metadata) we seems to have no embargoed dandisets at all ATM

❯ curl --silent -X 'GET' 'https://api.dandiarchive.org/api/dandisets/?page_size=1000&draft=true&empty=true&embargoed=true' -H 'accept: application/json' | jq . | grep -e embargo_status | sort | uniq -c
    350       "embargo_status": "OPEN",

and for that one it does list as OPEN too...

❯ curl --silent -X 'GET' \
  'https://api.dandiarchive.org/api/dandisets/000537/' \
  -H 'accept: application/json' | jq .
{
  "identifier": "000537",
  "created": "2023-05-10T13:47:21.630926Z",
  "modified": "2023-05-10T20:04:34.720627Z",
  "contact_person": "Adam Cohen",
  "embargo_status": "OPEN",
  "most_recent_published_version": null,
  "draft_version": {
    "version": "draft",
    "name": "Scaling of GEVI Fluorescence with 1P and 2P Illumination",
    "asset_count": 125,
    "size": 6440628584,
    "status": "Invalid",
    "created": "2023-05-10T13:47:21.642399Z",
    "modified": "2023-06-20T00:56:25.025519Z",
    "dandiset": {
      "identifier": "000537",
      "created": "2023-05-10T13:47:21.630926Z",
      "modified": "2023-05-10T20:04:34.720627Z",
      "contact_person": "Adam Cohen",
      "embargo_status": "OPEN"
    }
  }
}

so must be a discrepancy between status and metadata -- should have not metadata been changed after it went public? there definitely must be some WARNING if such incongruency is found, and it must be on dandi-archive level since dandi-schema itself would not know DB level status.

[dandibot]

🚀 Issue was released in v0.3.86 🚀