Major changes (ResponseObject, edited response hash) #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@12and1studio as usual 🚢
@evantahler another pull request you're welcome to review && comment ! Also maybe you would have other methods to add in the
ResponseObject
? 👍@dandemeyere we'll use it after a refact in the thredUP app 👓 👍
TODO
config.enabled= false
)Response object
Because our code often repeats the same basic operations on the hash, we'd like to make it more simple. So instead of using the response as a hash, this would force all our users to handle the response as a dev-friendly object. Yes it is.
Examples
Before
After
Methods on the
ResponseObject
thay may be interesting:success?
error?
error_code
error_message
error_desc
data
response_hash
Response hash
Also because it was the best occasion to do it, previously the response hash was:
But because it makes more sense, the status is now a boolean:
Helpers
Are a little refactored.