Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to libc 0.2.30 for emscripten support #20

Merged
merged 1 commit into from
Aug 27, 2017
Merged

Update to libc 0.2.30 for emscripten support #20

merged 1 commit into from
Aug 27, 2017

Conversation

lilianmoraru
Copy link
Contributor

No description provided.

@lilianmoraru
Copy link
Contributor Author

For some reason fails at this assert:

assert!(available_space <= free_space);

Curious if it is a test stability problem or in some version of libc something changed(I observed that the tests that passed use an old version of libc, so other versions might of changed the situation too).

@lilianmoraru
Copy link
Contributor Author

Probably flaky? It ran ok in my case: https://travis-ci.org/lilianmoraru/fs2-rs/builds/268981651

@lilianmoraru
Copy link
Contributor Author

Side note, the failing test ran on precise, while my run was on the newer trusty.

@danburkert
Copy link
Owner

Yep looks like a flake. Thanks for the PR! I imagine I should wait till resolution of #19 before cutting a release, right? AFAIK just this change alone isn't worth releasing, since cargo update in downstream apps should have the same effect.

@danburkert danburkert merged commit 7dd3410 into danburkert:master Aug 27, 2017
@lilianmoraru
Copy link
Contributor Author

@danburkert Yes, rust-lang/rust#44116 + #19 need to land first...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants