Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when useWindow=false, resize event is ignored #169

Open
mikabytes opened this issue Jul 24, 2018 · 8 comments
Open

when useWindow=false, resize event is ignored #169

mikabytes opened this issue Jul 24, 2018 · 8 comments
Labels

Comments

@mikabytes
Copy link

Describe the bug
I'm running infinite scroller within a div. When I resize the window to make it bigger, I can see white space at the end and the loadMore function is never called.

To Reproduce
https://codesandbox.io/s/ojo9vlvp35

Start the page with a very low window height, then when it has finished loading increase the height of the window and see that white space is showing and more items are not loaded.

Expected behavior
Items to be loaded when the parentNode has changed size.

Screenshots
image

Device (please complete the following information):
ubuntu 18.04, chrome 67

@azu-b
Copy link

azu-b commented Sep 10, 2018

I tried to reproduce the bug in a macOS High Sierra 10.13.6 and Chrome 68, and I couldn't 🤔
Record It.

If it still happens to you, could you please upload a gif screenshot to see exactly how to reproduce the bug?

Thanks 😄

@mikabytes
Copy link
Author

Hi there,

I believe an important step is not to scroll before resizing the window. Here you go, it's not a GIF but should be viewable in any browser: not-loading.ogv

It still happens to me. Let's see if maybe it's specific to Chrome on Linux?

@azu-b
Copy link

azu-b commented Sep 12, 2018

Hello again! Although I can't upload my gifs of me reproducing the bug, now I can tell the bug happens also in Chrome and in Safari in Mac 😢 .

@mikabytes
Copy link
Author

Ah perfect, one step closer to understanding the issue :)

@danbovey danbovey added the bug label Sep 14, 2018
@danbovey
Copy link
Owner

Thanks for the reproductions, the no-loading.ogv video makes it clear that we currently don't support useWindow without the scroll container being a fixed height. Looks like the container you have in the demo is styled like height: 90vh.

@mikabytes
Copy link
Author

Yes, this is true. It needs to be dynamic for my project. Anyone up for fixing this? I'm pressed for time, but if no one else does it I might try to give it a shot in the weekend

@Alphonse-Indpro
Copy link

Alphonse-Indpro commented Sep 11, 2020

@danbovey Any solution to this? Many pull requests related is not yet merged. Any specific reason for that?
#241
#132

@mikabytes How did you solve it?

@mikabytes
Copy link
Author

@Alphonse-Indpro Ah two years later. I never got around to fix it. I migrated to Web Components and stopped using React altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants