On Line 86 we detach the event listener and call loadMore, this is where the logic for hasMore is updated by you from an XHR response or similar. Then if the component updates it attaches the event listener, only if hasMore is true.

But I suppose your question is, what would happen if you changed the hasMore prop outside of this process? It wouldn't detach until the above process is made again 😕

I'll see if we can make the same check made by the attach method in scrollListener as well.

if(!this.props.hasMore) {
    return;
}

Thanks for the answer and explanation.

But I suppose your question is, what would happen if you changed the hasMore prop outside of this process?

Yes, that's exactly what I meant. This makes it troublesome if say, I simply want to make a button to attach/detach the event listeners. The doc could be clearer as well, as it states that the event listeners are removed if hasMore is false.

It probably is, I'm swamped with uni work right now so I haven't had a chance to test it.

dantzchan@506138f

This kinda works, I check hasMore on componentWillReceiveProps and detachScrollListener if hasMore is false.

this component has a lot of bugs 🤨🤨

I have the same issue, with an ordinary scenario - I have two "tabs" (basically buttons) that fetch data and display it in an infinite scrolling. First (default) tab doesn't have more items (most of the time), but second tab has more items (archived from first tab). When switching from first to second I set hasMore to true and it works. But when switching back to first tab I set hasMore back to false and it still tries to make request to the server for more data.

I get the same problem, any plans on merging pull requests that might fix the problem and release a new version?