Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of NIP-10 (nip-10 other client updates might cause trouble) #2145

Closed
alltheseas opened this issue Apr 15, 2024 · 9 comments · Fixed by #2190
Closed
Labels
duplicate This issue or pull request already exists interop interoperability and compatibility with other nostr apps NIP technical

Comments

@alltheseas
Copy link
Collaborator

Team is anticipating trouble, as discussed between @danieldaquino and @jb55 on @tyiu changes to Primal

@alltheseas alltheseas added technical Needs recreation Issues requires concrete steps for recreation labels Apr 15, 2024
@alltheseas alltheseas added the NIP label Apr 15, 2024
@alltheseas
Copy link
Collaborator Author

see #528

@alltheseas
Copy link
Collaborator Author

@tyiu commit PrimalHQ/primal-ios-app@dbefe05

@alltheseas alltheseas moved this to Backlog in Damus Roadmap 🛣️ Apr 18, 2024
@alltheseas alltheseas changed the title TBC: nip-10 other client updates might cause trouble Update to latest version of NIP-10 (nip-10 other client updates might cause trouble) Apr 18, 2024
@alltheseas
Copy link
Collaborator Author

"Thank you! Although we should really update lol" - @jb55 on @tyiu update on Primal repo of NIP-10 to be backwards compatible

@alltheseas
Copy link
Collaborator Author

@tyiu how much work would it be to apply the same nip-10 patch to damus?

cc @danieldaquino @jb55

@alltheseas alltheseas added the interop interoperability and compatibility with other nostr apps label Apr 25, 2024
@alltheseas
Copy link
Collaborator Author

Lmk how many candles orders its worth to you @tyiu

@jb55 jb55 linked a pull request Apr 25, 2024 that will close this issue
3 tasks
@alltheseas
Copy link
Collaborator Author

@jb55 is nip-10 update published to testflight?

@jb55
Copy link
Collaborator

jb55 commented May 2, 2024 via email

@alltheseas
Copy link
Collaborator Author

duplicate #528

@jb55
Copy link
Collaborator

jb55 commented May 6, 2024

Closing because dup of:

Trying to get our issue numbers down a bit 😅

@jb55 jb55 closed this as completed May 6, 2024
@alltheseas alltheseas added the duplicate This issue or pull request already exists label May 6, 2024
@jb55 jb55 moved this from Backlog to Done in Damus Roadmap 🛣️ May 10, 2024
@jb55 jb55 moved this from Done to Live in Damus Roadmap 🛣️ May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists interop interoperability and compatibility with other nostr apps NIP technical
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants