Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication and Progress handler overwriting each other in the git_fetch_options payload #18

Open
m3ta4a opened this issue Dec 31, 2016 · 0 comments

Comments

@m3ta4a
Copy link

m3ta4a commented Dec 31, 2016

The Progress class seems currently incomplete but even with changes to make it functional I've run into an issue where the fetch options payload gets set twice, first with a Progress object followed by an Authentication object. This results in crashes in the progress handling, since the payload is no longer what was expected. I've begun working on a way to handle this but before I submit a pull request I thought I'd open an issue in case there was reasoning for this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant