Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 3.1.0 Info.plist set to 3.0.5 #703

Closed
dessmith opened this issue Oct 10, 2019 · 5 comments
Closed

Version 3.1.0 Info.plist set to 3.0.5 #703

dessmith opened this issue Oct 10, 2019 · 5 comments

Comments

@dessmith
Copy link

The Info.plist in version / tag 3.1.0 is set to

Version 3.1.0 Info.plist set to 3.0.5

	<key>CFBundleShortVersionString</key>
	<string>3.0.5</string>

This caused me a few hours of head scratching when dealing I was updating multiple framework dependancies and wondering why Carthage kept getting 3.0.5 of Starscream.

Please fix in a future release, thanks.
@fassko
Copy link
Collaborator

fassko commented Oct 10, 2019

Hey @dessmith could you help out with a PR? I will merge it. Thanks!

@dessmith
Copy link
Author

@fassko Sure I can set the version to 3.1.0 would you move the git tag to fix, or would it be a new version?

@fassko
Copy link
Collaborator

fassko commented Oct 10, 2019

Let's make it as a patch version 3.1.1 Thanks!

@dessmith dessmith mentioned this issue Oct 10, 2019
Merged
@dessmith
Copy link
Author

dessmith commented Oct 10, 2019 •
edited
Loading

@fassko PR #704 raised, thanks

@fassko fassko closed this as completed Oct 14, 2019
@fassko
Copy link
Collaborator

fassko commented Oct 14, 2019

Thanks @dessmith! Version got updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fassko @dessmith