Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket class should be 'open' not 'public' #265

Closed
fjcaetano opened this issue Oct 10, 2016 · 0 comments · Fixed by #266
Closed

WebSocket class should be 'open' not 'public' #265

fjcaetano opened this issue Oct 10, 2016 · 0 comments · Fixed by #266

Comments

@fjcaetano
Copy link
Contributor

Defining classes with public access control keeps them from being "subclassable" outside its defining module. The behaviour is similar to declaring a class as final.

Therefore, WebSocket should be open which means it is public and inheritable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

'Open'ing classes fjcaetano/Starscream
1 participant
@fjcaetano