Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is DTGP required on hotpatches? #133

Closed
sakoula opened this issue Dec 31, 2018 · 4 comments
Closed

Is DTGP required on hotpatches? #133

sakoula opened this issue Dec 31, 2018 · 4 comments
Labels

Comments

@sakoula
Copy link

sakoula commented Dec 31, 2018

Hi,
I have noticed that many hotpatches include External (DTGP, MethodObj) such as SSDT-RMNE.dsl. Do they require the DTGP patch? If yes why is that.

for example SSDT-RMNE.dsl at RehabMan's site does not include the DTGP method/patch

Thanks!

@sakoula sakoula changed the title Is DTGP required on hotpatches Is DTGP required on hotpatches? Dec 31, 2018
@stevezhengshiqi
Copy link
Collaborator

stevezhengshiqi commented Dec 31, 2018

Hi,
DTGP method is not required in SSDTs necessarily. I guess the method is only used to check UUID, and a piece of generic code is injected into our DSDT. In Rehabman's repo, he uses
If (!Arg2) { Return (Buffer() { 0x03 } ) }
to replace DTGP method, which is good and simple.

The reason I use DTGP method is that many real MacBookPros use that. I want our devices behave more natively. Here are two DSDT examples from MacBookPro14,1 and MacBookPro14,2 and you can see that almost every _DSM method followed by a DTGP method.(Please don't share, these files are just for hackintosh study!)
MacBook Pro-14.1.acpi.zip
MacBookPro14,2.dsl.zip

@sakoula
Copy link
Author

sakoula commented Dec 31, 2018

Hi, Thanks a lot for you super detailed reply. Actually I have a Xiaomi Mi Notebook Air 13.3'' (i5 6200U) and I am trying to learn while converting it to a hackintosh! The XiaoMi-Pro repository is an amazing knowledge treasure for me. Well done!!!

May I ask a couple of questions?

  1. How did you make the CPUFriendDataProvider for the Pro? Can you point me to some documentation/thread to start experimenting with (my battery life sucks). Does it make sense to install the Pro provider? I assume that it is a totally different architecture and will not be compatible.

  2. I have big trouble with VoodooI2C. How can I tell the type of touchpad that I have? What tools are you using in Windows to see details of the devices? I cannot see the I2C devices under ioreg by no means.

Sorry for all these questions!

Thanks! and Happy new year!

@stevezhengshiqi
Copy link
Collaborator

Happy new year! I am glad that you like my work.

  1. I think you need to generate an unique CPUDataProvider because you have a different generation CPU. Full instruction is at:https://github.com/acidanthera/CPUFriend/blob/master/Instructions.md
    I have explained my process before at 10th floor in #22, which may help you.
    A easier way is to choose a compatible SMBIOS and check plugin-type in config.plist

  2. For VoodooI2C, full instruction is at here. You can go to Device Manager and find your trackpad.

@sakoula
Copy link
Author

sakoula commented Jan 2, 2019

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants