Add getrandom feature that enables builtin new_random constructors (see issue #85)
#103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkforest
added a commit
to pinkforest/x25519-dalek
that referenced
this pull request
Mar 12, 2023
This is a reroll of dalek-cryptography#103 to correct branch Co-authored-by: Ciprian Dorin Craciun <[email protected]>
Closed
|
This was in the wrong branch so #113 supercedes this - I added co-authored-by so you get the credit ;) |
|
@pinkforest no problem, thanks for the credit. I'll close this pull request then. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is trivial and just adds a helper function
new_randomforEphemeralSecret,StaticSecretandReusableSecretthat just delegates toSelf::new(&mut rand_core::OsRng), thus solving #85.This feature is hidden behind the
getrandomfeature (that enablesrand_core/getrandom).There are no added tests, because the implementation is trivial.