Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublicKey should derive Hash #120

Closed
dvc94ch opened this issue Feb 24, 2020 · 1 comment
Closed

PublicKey should derive Hash #120

dvc94ch opened this issue Feb 24, 2020 · 1 comment

Comments

@dvc94ch
Copy link

dvc94ch commented Feb 24, 2020

Unless there's a cryptographic reason why it should not derive Hash, it would be a good idea.
@burdges
Copy link

burdges commented Feb 25, 2020 •
edited
Loading

It should define Hash with .0.as_bytes() not #[derive(Hash)] since the serialized form already exists, and because points in protective coordinates require normalization. Aside from the obvious reasons: Projective Coordinates Leak

@dvc94ch dvc94ch closed this as completed Feb 25, 2020
@cyphar cyphar mentioned this issue Mar 22, 2020
Closed
@inetic inetic mentioned this issue Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@burdges @dvc94ch