Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curve25519: nightly CI seems borked w/ warn(unused_imports) #637

Closed
pinkforest opened this issue Feb 26, 2024 · 0 comments · Fixed by #638
Closed

curve25519: nightly CI seems borked w/ warn(unused_imports) #637

pinkforest opened this issue Feb 26, 2024 · 0 comments · Fixed by #638

Comments

@pinkforest
Copy link
Contributor

pinkforest commented Feb 26, 2024

Happened on my PR:

https://github.com/dalek-cryptography/curve25519-dalek/actions/runs/8051602263/job/21989865551?pr=636

Seems there is a new lint or something w/ nightly relating to redundant imports ?

warning: the item `Eq` is imported redundantly
   --> curve25519-dalek/src/scalar.rs:115:17
    |
115 | use core::cmp::{Eq, PartialEq};
    |                 ^^
    |
   ::: /home/foobar/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/prelude/mod.rs:38:13
    |
38  |     pub use super::v1::*;
    |             --------- the item `Eq` is already defined here
    |
    = note: `#[warn(unused_imports)]` on by default

warning: the item `PartialEq` is imported redundantly
   --> curve25519-dalek/src/scalar.rs:115:21
    |
115 | use core::cmp::{Eq, PartialEq};
    |                     ^^^^^^^^^
    |

To resolve need to remove the redundant imports warns.

EDIT: Oh wait this is something how prelude may have changed / borkd ? :O

EDIT.2: Seems a new lint for redundant imports ?

warning: the item `RngCore` is imported redundantly
    --> curve25519-dalek/src/edwards.rs:1603:9
     |
1593 |     use super::*;
     |         -------- the item `RngCore` is already imported here
...
1603 |     use rand_core::RngCore;
     |         ^^^^^^^^^^^^^^^^^^
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant