From e5efe1660bc953cf0eeabedfd0aa0082c4d0d62a Mon Sep 17 00:00:00 2001 From: Dale Henrichs Date: Tue, 7 Oct 2014 16:20:52 -0700 Subject: [PATCH] Issue #48: first order of business is to determine whether or not these tests are being run... --- .../crossPlatformPathFromArray.finalSlash..st | 4 ++-- .../instance/testAsAbsoluteUrlRelativeTo.st | 8 +++++++- .../instance/testPathForRequest.st | 14 ++++++++++---- .../methodProperties.json | 6 +++--- .../monticello.meta/version | 3 +-- 5 files changed, 23 insertions(+), 12 deletions(-) diff --git a/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/crossPlatformPathFromArray.finalSlash..st b/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/crossPlatformPathFromArray.finalSlash..st index 10262bc9c..7704999ae 100644 --- a/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/crossPlatformPathFromArray.finalSlash..st +++ b/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/crossPlatformPathFromArray.finalSlash..st @@ -1,7 +1,7 @@ testing crossPlatformPathFromArray: pathArray finalSlash: finalSlash | separator path| - separator := String with: SpFilename new separator. + separator := GRPlatform current pathSeparator. path := String new. pathArray do: [:pathElement | @@ -9,4 +9,4 @@ crossPlatformPathFromArray: pathArray finalSlash: finalSlash finalSlash ifTrue: [ path:= path, separator]. - ^ path + ^ path \ No newline at end of file diff --git a/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/testAsAbsoluteUrlRelativeTo.st b/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/testAsAbsoluteUrlRelativeTo.st index 29b3f99eb..31adece32 100644 --- a/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/testAsAbsoluteUrlRelativeTo.st +++ b/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/testAsAbsoluteUrlRelativeTo.st @@ -1,6 +1,9 @@ testing testAsAbsoluteUrlRelativeTo | request | + Transcript + cr; + show: 'WAExternalFileLibraryTest>>testAsAbsoluteUrlRelativeTo [0]'. fileSystem configuration at: #directory put: '/home/philppe/pr0n'. @@ -11,4 +14,7 @@ testAsAbsoluteUrlRelativeTo request := self requestWithUrl: '/culture/pictures/'. self assert: (fileSystem asAbsoluteUrl: 'cleopatra.jpeg' - relativeTo: request) greaseString = '/culture/pictures/cleopatra.jpeg' \ No newline at end of file + relativeTo: request) greaseString = '/culture/pictures/cleopatra.jpeg'. + Transcript + cr; + show: 'WAExternalFileLibraryTest>>testAsAbsoluteUrlRelativeTo [1]'. \ No newline at end of file diff --git a/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/testPathForRequest.st b/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/testPathForRequest.st index 5f8eb3c42..afc197d82 100644 --- a/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/testPathForRequest.st +++ b/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/instance/testPathForRequest.st @@ -4,6 +4,9 @@ testPathForRequest | consumer requestPath resultPath filename | + Transcript + cr; + show: 'WAExternalFileLibraryTest>>testPathForRequest [0]'. "/home/philppe/files" requestPath := self crossPlatformPathFromArray: #('home' 'philppe' 'files') finalSlash: false. fileSystem configuration at: #directory put: requestPath. @@ -14,7 +17,7 @@ testPathForRequest "/home/philppe/files/cleopatra.jpeg" resultPath := self crossPlatformPathFromArray: #('home' 'philppe' 'files' 'cleopatra.jpeg') finalSlash: false. filename := fileSystem filenameForConsumer: consumer. - self assert: filename asString "on SpFileName" = resultPath. + self assert: filename = resultPath. consumer := WAPathConsumer path: #('culture' 'cleopatra.jpeg') asOrderedCollection. @@ -26,7 +29,7 @@ testPathForRequest "/home/philppe/files/cleopatra.jpeg" resultPath := self crossPlatformPathFromArray: #('home' 'philppe' 'files' 'cleopatra.jpeg') finalSlash: false. filename := fileSystem filenameForConsumer: consumer. - self assert: filename greaseString = resultPath. + self assert: filename = resultPath. consumer := WAPathConsumer path: #('cleopatra.jpeg') asOrderedCollection. @@ -36,7 +39,7 @@ testPathForRequest "/home/philppe/files/cleopatra.jpeg" resultPath := self crossPlatformPathFromArray: #('home' 'philppe' 'files' 'cleopatra.jpeg') finalSlash: false. - self assert: (fileSystem filenameForConsumer: consumer) greaseString = resultPath. + self assert: (fileSystem filenameForConsumer: consumer) = resultPath. consumer := WAPathConsumer path: #('cleopatra.jpeg') asOrderedCollection. @@ -47,4 +50,7 @@ testPathForRequest consumer := WAPathConsumer path: #('cleopatra.jpeg') asOrderedCollection. "/home/philppe/files/cleopatra.jpeg" resultPath := self crossPlatformPathFromArray: #('home' 'philppe' 'files' 'cleopatra.jpeg') finalSlash: false. - self assert: (fileSystem filenameForConsumer: consumer) greaseString = resultPath. \ No newline at end of file + self assert: (fileSystem filenameForConsumer: consumer) = resultPath. + Transcript + cr; + show: 'WAExternalFileLibraryTest>>testPathForRequest [1]'. \ No newline at end of file diff --git a/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/methodProperties.json b/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/methodProperties.json index 801144187..cc48b3dd1 100644 --- a/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/methodProperties.json +++ b/repository/Seaside-Tests-FileSystem.package/WAExternalFileLibraryTest.class/methodProperties.json @@ -2,9 +2,9 @@ "class" : { }, "instance" : { - "crossPlatformPathFromArray:finalSlash:" : "NickAger 9/5/2009 14:27", + "crossPlatformPathFromArray:finalSlash:" : "JohanBrichau 9/27/2014 16:40", "requestWithUrl:" : "lr 8/2/2009 12:50", "setUp" : "pmm 9/5/2009 15:55", - "testAsAbsoluteUrlRelativeTo" : "JohanBrichau 9/13/2013 10:30", + "testAsAbsoluteUrlRelativeTo" : "dkh 10/07/2014 16:17", "testMimetypeForRequest" : "pmm 10/18/2008 11:31", - "testPathForRequest" : "JohanBrichau 9/13/2013 10:30" } } + "testPathForRequest" : "dkh 10/07/2014 16:16" } } diff --git a/repository/Seaside-Tests-FileSystem.package/monticello.meta/version b/repository/Seaside-Tests-FileSystem.package/monticello.meta/version index 378dba73a..e8f5b1456 100644 --- a/repository/Seaside-Tests-FileSystem.package/monticello.meta/version +++ b/repository/Seaside-Tests-FileSystem.package/monticello.meta/version @@ -1,2 +1 @@ -(name 'Seaside-Tests-FileSystem-JohanBrichau.14' message 'Fixing tests for Seaside3.1' id 'dd39cba8-efa5-47e8-96f9-b7725b33acde' date '13 September 2013' time '10:31:12.098 am' author 'JohanBrichau' ancestors ((name 'Seaside-Tests-FileSystem-lr.13' message '- set package url' id '5b5baee4-7a0e-4cdd-aa60-1f7bb125971e' date '10 February 2010' time '11:35:21 am' author 'lr' ancestors ((name 'Seaside-Tests-FileSystem-lr.12' message '- fixed package description' id '828d6d9d-eb86-49a7-978c-f034756e56ec' date '25 October 2009' time '11:37:07 am' author 'lr' ancestors ((name 'Seaside-Tests-FileSystem-obi.11' message '- package is LGPL' id 'c24b4c72-bedf-c542-aeb3-38a70ccca504' date '8 October 2009' time '8:33:20 am' author 'obi' ancestors ((name 'Seaside-Tests-FileSystem-obi.10' message '- add (LGPL) to package description' id '3e12ace5-b44d-1a43-aacf-ba3800183e94' date '6 October 2009' time '5:29:41 pm' author 'obi' ancestors ((name 'Seaside-Tests-FileSystem-jf.9' message 'Update to use Grease' id 'da9f7580-e5a5-4aff-bb3a-91f8eb74a335' date '30 September 2009' time '10:42:27 pm' author 'jf' ancestors ((name 'Seaside-Tests-FileSystem-pmm.8' message '- fixed test' id '02f2de25-e252-41d1-8583-e3235e73ba9a' date '5 September 2009' time '4:03:16 pm' author 'pmm' ancestors ((name 'Seaside-Tests-FileSystem-pmm.7' message '- add package information' id '75f2f54d-84af-4c95-b711-934b97ae0fa8' date '5 September 2009' time '3:53:17 pm' author 'pmm' ancestors ((name 'Seaside-Tests-FileSystem-NickAger.6' message 'completed changes to WAExternalFileLibraryTest for issue 235 (http://code.google.com/p/seaside/issues/detail?id=235) - however untested - updated to allow philippe to check Library path modifications' id '7998420d-b117-d946-ae4a-5c93c6710336' date '5 September 2009' time '2:45:37 pm' author 'NickAger' ancestors ((name 'Seaside-Tests-FileSystem-NickAger.5' message 'started working on: Issue 235: WAExternalFileLibraryTest>>testPathForRequest fails on windows http://code.google.com/p/seaside/issues/detail?id=235 .. but didn''t complete...' id '956f7b8d-19a9-754a-8f20-b32d401c7ccf' date '4 September 2009' time '7:19:51 pm' author 'NickAger' ancestors ((name 'Seaside-Tests-FileSystem-lr.4' message '- fixed a problem in the tests introduced by the latest WAHttpVersion refactoring' id 'a6b4c15b-560c-437b-a0ed-dfa4dcc027e6' date '2 August 2009' time '12:51:28 pm' author 'lr' ancestors ((name 'Seaside-Tests-FileSystem-pmm.3' message '- updated tests' id 'c23abe9e-8486-4bd3-aa0a-7a8e9046085e' date '18 July 2009' time '10:18:16 am' author 'pmm' ancestors ((name 'Seaside-Tests-FileSystem-mls.2' message '- Added a package comment' id 'b297982a-1ede-4d21-b5e5-b1f482ac717b' date '4 June 2009' time '9:53:43 am' author 'mls' ancestors ((name 'Seaside-Tests-FileSystem-pmm.1' message '- version bump after renaming -- working with latest 2.9' id 'd238ee2d-40b1-400d-912a-4346df0939c7' date '18 October 2008' time '12:31:25 pm' author 'pmm' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ()) \ No newline at end of file +(name 'Seaside-Tests-FileSystem-dkh.16' message 'Issue #48: first order of business is to determine whether or not these tests are being run...' id '6c51b911-e3f8-4a93-b717-3d90cfe89511' date '10/07/2014' time '16:20:52' author 'dkh' ancestors ((name 'Seaside-Tests-FileSystem-JohanBrichau.15' message 'Removed dependency on Sport (tests might need some more cleanup)' id '787bd999-d18d-44a6-8972-d9ab6c77afbe' date '09/28/2014' time '01:35:58' author 'JohanBrichau' ancestors ((name 'Seaside-Tests-FileSystem-JohanBrichau.14' message 'Fixing tests for Seaside3.1' id 'dd39cba8-efa5-47e8-96f9-b7725b33acde' date '09/13/2013' time '10:31:12' author 'JohanBrichau' ancestors ((name 'Seaside-Tests-FileSystem-lr.13' message '- set package url' id '5b5baee4-7a0e-4cdd-aa60-1f7bb125971e' date '02/10/2010' time '11:35:21' author 'lr' ancestors ((name 'Seaside-Tests-FileSystem-lr.12' message '- fixed package description' id '828d6d9d-eb86-49a7-978c-f034756e56ec' date '10/25/2009' time '11:37:07' author 'lr' ancestors ((name 'Seaside-Tests-FileSystem-obi.11' message '- package is LGPL' id 'c24b4c72-bedf-c542-aeb3-38a70ccca504' date '10/08/2009' time '08:33:20' author 'obi' ancestors ((name 'Seaside-Tests-FileSystem-obi.10' message '- add (LGPL) to package description' id '3e12ace5-b44d-1a43-aacf-ba3800183e94' date '10/06/2009' time '17:29:41' author 'obi' ancestors ((name 'Seaside-Tests-FileSystem-jf.9' message 'Update to use Grease' id 'da9f7580-e5a5-4aff-bb3a-91f8eb74a335' date '09/30/2009' time '22:42:27' author 'jf' ancestors ((name 'Seaside-Tests-FileSystem-pmm.8' message '- fixed test' id '02f2de25-e252-41d1-8583-e3235e73ba9a' date '09/05/2009' time '16:03:16' author 'pmm' ancestors ((name 'Seaside-Tests-FileSystem-pmm.7' message '- add package information' id '75f2f54d-84af-4c95-b711-934b97ae0fa8' date '09/05/2009' time '15:53:17' author 'pmm' ancestors ((name 'Seaside-Tests-FileSystem-NickAger.6' message 'completed changes to WAExternalFileLibraryTest for issue 235 (http://code.google.com/p/seaside/issues/detail?id=235) - however untested - updated to allow philippe to check Library path modifications' id '7998420d-b117-d946-ae4a-5c93c6710336' date '09/05/2009' time '14:45:37' author 'NickAger' ancestors ((name 'Seaside-Tests-FileSystem-NickAger.5' message 'started working on: Issue 235: WAExternalFileLibraryTest>>testPathForRequest fails on windows http://code.google.com/p/seaside/issues/detail?id=235 .. but didn''t complete...' id '956f7b8d-19a9-754a-8f20-b32d401c7ccf' date '09/04/2009' time '19:19:51' author 'NickAger' ancestors ((name 'Seaside-Tests-FileSystem-lr.4' message '- fixed a problem in the tests introduced by the latest WAHttpVersion refactoring' id 'a6b4c15b-560c-437b-a0ed-dfa4dcc027e6' date '08/02/2009' time '12:51:28' author 'lr' ancestors ((name 'Seaside-Tests-FileSystem-pmm.3' message '- updated tests' id 'c23abe9e-8486-4bd3-aa0a-7a8e9046085e' date '07/18/2009' time '10:18:16' author 'pmm' ancestors ((name 'Seaside-Tests-FileSystem-mls.2' message '- Added a package comment' id 'b297982a-1ede-4d21-b5e5-b1f482ac717b' date '06/04/2009' time '09:53:43' author 'mls' ancestors ((name 'Seaside-Tests-FileSystem-pmm.1' message '- version bump after renaming - working with latest 2.9' id 'd238ee2d-40b1-400d-912a-4346df0939c7' date '10/18/2008' time '12:31:25' author 'pmm' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ()) \ No newline at end of file