We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.8.3
Executing gci on the following source code removes the comment // Test on the struct which is following the imports.
// Test
It seems as the changed parsing logic is not respecting comments which might exist on a top level declaration: https://github.com/daixiang0/gci/blob/master/pkg/parse/parse.go#L115-L117
package main import ( "fmt" _ "github.com/golang" // golang "github.com/daixiang0/gci" ) // Test type Test struct { }
->
package main import ( "fmt" _ "github.com/golang" // golang "github.com/daixiang0/gci" ) type Test struct { }
Only imports should be modified - comments of following declarations (e.g. structs) should not be removed.
The comment of following declarations (e.g. structs) are getting removed.
The text was updated successfully, but these errors were encountered:
I saw that #120 mentions the following
introduce breaking change: remove isolated comments
but i don't think that this is an "isolated comment"
Sorry, something went wrong.
#124 would fix this, thanks for report.
No branches or pull requests
What version of GCI are you using?
Reproduce Steps
Executing gci on the following source code removes the comment
// Test
on the struct which is following the imports.It seems as the changed parsing logic is not respecting comments which might exist on a top level declaration: https://github.com/daixiang0/gci/blob/master/pkg/parse/parse.go#L115-L117
->
What did you expect to see?
Only imports should be modified - comments of following declarations (e.g. structs) should not be removed.
What did you see instead?
The comment of following declarations (e.g. structs) are getting removed.
The text was updated successfully, but these errors were encountered: