Error: 19:1: expected 'STRING', found 'type' (and 10 more errors)

[hawkingrei]

What version of GCI are you using?

gci version 0.8.2

Reproduce Steps

git clone https://gitlab.com/cznic/sortutil.git
cd sortutil
gci write -s standard -s default sortutil.go

Error: requires at least 1 arg(s), only received 0

What did you expect to see?

not print error

What did you see instead?

return error

[daixiang0]

@hawkingrei thanks for the report, please try master HEAD, it would be fixed.

[hawkingrei]

@daixiang0 I upgrade it in our CI and find new problems.When gci enable write mode. it will remove comments and have a false-positive phenomenon.

https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fghpr_build/detail/ghpr_build/5907/pipeline/91

[hawkingrei]

You can test it in tidb repo.

[daixiang0]

I see some format problems left over by history, now the failed file testkit/testmain/bench.go has been fixed in master HEAD.

root:[tidb]$ git log testkit/testmain/bench.go
* 6da6e5a57 - *: fix build tag by run gofix (#34260) (7 months ago) <Weizhen Wang>
* b74c13a89 - *: run go fmt in go1.17 (#28784) (1 year ago) <Weizhen Wang>
* 5a4ee311f - test: implement ShortCircuitForBench (#28732) (1 year, 1 month ago) <tison>
root:[tidb]$ gci diff testkit/testmain/bench.go
root:[tidb]$

To ensure no false-positive phenomenon, you can try goimports first then run gci.

[daixiang0]

@hawkingrei if no issues left, I will close it.