Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epub-pagesource when no page breaks detected #86

Closed
laudrain opened this issue Oct 18, 2017 · 5 comments
Closed

epub-pagesource when no page breaks detected #86

laudrain opened this issue Oct 18, 2017 · 5 comments
Assignees

Comments

@laudrain
Copy link

A 'dc:source' metadata property is asked even when there are no page breaks detected.

@rdeltour rdeltour added this to the Beta 2 milestone Oct 18, 2017
@rdeltour rdeltour self-assigned this Oct 18, 2017
@rdeltour
Copy link
Member

A 'dc:source' metadata property is asked even when there are no page breaks detected.

Doh. That would certainly be a bug. I'll try to reproduce and fix for the next release. Thanks!

@rdeltour
Copy link
Member

@laudrain I can't reproduce this. Would you have a sample EPUB to share?

@rdeltour
Copy link
Member

By the way, the rule (which is sadly poorly documented) is to check the a dc:source is provided when page navigation is present (like a page-list in the Navigation Document).

There should be another rule to check such page navigation is present when page breaks are found, but that's for another rule (not implemented yet)

/cc @mattgarrish

@rdeltour rdeltour added invalid and removed bug labels Oct 25, 2017
@rdeltour rdeltour removed this from the v0.6.0 “Beta 2” milestone Oct 25, 2017
@rdeltour
Copy link
Member

Removing the bug label and moving out of the v0.6.0 milestone. It can be reincluded if @laudrain provides more info.

@laudrain
Copy link
Author

@rdeltour I understand how dc:source is related to page-breaks.
Without a nav entry of epub:type="page-list" in the nav.xhtml file, the dc:source isn't any more required.
So I close this issue.
There is an issue about page-break detection which is #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants