fix: allow list of values for 'accessModeSufficient'

Fixes #238
daisy · Jul 8, 2019 · 6cb5402 · 6cb5402
1 parent 0f9e656
commit 6cb5402
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/packages/ace-core/src/checker/checker-epub.js b/packages/ace-core/src/checker/checker-epub.js
@@ -159,6 +159,9 @@ function checkMetadata(assertions, epub) {
       if (!Array.isArray(values)) {
         values = [values]
       }
+      // Parse list values
+      values = values.map(value => value.trim().replace(',', ' ').replace(/\s{2,}/g, ' ').split(' '))
+      values = [].concat(...values);
       // Check metadata values are allowed
       // see https://www.w3.org/wiki/WebSchemas/Accessibility
       if (meta.allowedValues) {

diff --git a/tests/__tests__/epub-rules.test.js b/tests/__tests__/epub-rules.test.js
@@ -77,6 +77,13 @@ describe('accessibility metadata', () => {
         }),
       }),
     ]));
+    expect(assertions).not.toEqual(expect.arrayContaining([
+      expect.objectContaining({
+        'earl:test': expect.objectContaining({
+          'dct:title': 'metadata-accessmodesufficient-invalid',
+        }),
+      }),
+    ]));
   });
   test('`printPageNumbers` is declared as a feature but the Nav Doc has no page list', async () => {
     const report = await ace('../data/epubrules-metadata-printPageNumbers-nopagelist');

diff --git a/tests/data/epubrules-metadata/EPUB/package.opf b/tests/data/epubrules-metadata/EPUB/package.opf
@@ -13,7 +13,7 @@
   <meta property="schema:accessibilityHazard">noMotionSimulationHazard</meta>
   <!-- Fail #2: bad metadata value -->
   <meta property="schema:accessMode">text</meta>
-  <meta property="schema:accessModeSufficient">textual</meta>
+  <meta property="schema:accessModeSufficient">visual,textual</meta>
 </metadata>
 <manifest>
   <item id="nav"  href="nav.xhtml" media-type="application/xhtml+xml" properties="nav"/>