Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processing time #49

Closed
thiagoeec opened this issue May 12, 2019 · 4 comments
Closed

Processing time #49

thiagoeec opened this issue May 12, 2019 · 4 comments

Comments

@thiagoeec
Copy link
Contributor

The GUI is taking 3 times longer than the command line tool (one particular file took me 6,5s to check with the command line tool, and 21s on the GUI; another took 13.3s and 43s; and so on).
Maybe some delay could happen, since it loads the repport inside the application, but this seems like a lot.

*My notebook has i7 7700hq and 16GB or ram. I don't think is hardware limitation.

@danielweck
Copy link
Member

Hello, are you using this beta release?
https://github.com/daisy/ace-gui/releases/tag/v1.0.0-beta.2

If so, then I have a pretty good idea where this performance discrepancy may be coming from. I will be running some tests to compare timings. Thanks a lot for your feedback!

@thiagoeec
Copy link
Contributor Author

thiagoeec commented May 13, 2019

Hello, are you using this beta release?
https://github.com/daisy/ace-gui/releases/tag/v1.0.0-beta.2

If so, then I have a pretty good idea where this performance discrepancy may be coming from. I will be running some tests to compare timings. Thanks a lot for your feedback!

Yes! The lastest beta available.

@danielweck
Copy link
Member

This is now fixed (but not yet released). The performance of Ace CLI and Ace GUI are now identical.

Ace CLI uses a Puppeteer-based Axe runner, whereas Ace GUI uses an Electron one. Both Axe runners are now included in the ace (core) repository, and ace-gui will be updated soon (in the commit month) to use the improved Axe runner. Both Axe runners can be executed and compared in the ace (core) repository, via the command line. There is a pending Pull Request, currently in "Work In Progress" state. More information:
daisy/ace#236 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants