Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(response): [NO-TICKET] parsed_response tests and json support #31

Merged
merged 1 commit into from
Jan 5, 2024
Merged

feat(response): [NO-TICKET] parsed_response tests and json support #31

merged 1 commit into from
Jan 5, 2024

Conversation

harry-stebbins-dailypay
Copy link
Contributor

What

  • Add tests around parsed_response is constructed
  • Add support for a larger subset of JSON responses
    • top-level arrays
    • nested objects
    • nested arrays

Why

  • fewer surprises for consumers of the HTTPigeon API

Related Links

2k-joker
2k-joker approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@2k-joker 2k-joker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thx!

@harry-stebbins-dailypay harry-stebbins-dailypay force-pushed the no-ticket/parsed-response-tests branch from 3f7749b to a1d1cb1 Compare December 22, 2023 17:09
remzelg
remzelg approved these changes Jan 3, 2024
View reviewed changes
Copy link

@remzelg remzelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor + tests 👍

@2k-joker 2k-joker merged commit e169215 into main Jan 5, 2024
4 checks passed
@2k-joker 2k-joker deleted the no-ticket/parsed-response-tests branch January 5, 2024 20:20
@github-actions github-actions bot mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2k-joker 2k-joker 2k-joker approved these changes

@remzelg remzelg remzelg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harry-stebbins-dailypay @remzelg @2k-joker