fix(request): Handle edge cases in response parsing

[2k-joker]

What

Account for stuff like this:

NoMethodError: undefined method `with_indifferent_access' for []:Array

      JSON.parse(response_body).with_indifferent_access

Why

Not everyone designs proper json APIs

[harry-stebbins-dailypay]

this will still break in the case where the elements of the top-level array are themselves arrays or non-Object in general

for example, it would break on this valid json response in several different ways:

[
  {
    "foo": "bar"
  },
  1,
  "foobar",
  true,
  null,
  [
    {
      "inner": "object"
    },
    1,
    null,
    []
  ]
]

consider modifying the contract of the library to only return string-type json and thus eliminate this problem entirely -- simply don't try 😆

or, consider a safe recursive "deep with indifferent access." maybe something like this

def deep_with_indifferent_access(obj)
  case obj
  when Hash
    obj.each_with_object({}) do |(key, value), memo|
      memo[key] = deep_with_indifferent_access(value)
    end.with_indifferent_access
  when Array
    obj.map { |item| deep_with_indifferent_access(item) }
  else
    obj
  end
end

test = JSON.parse('[{"foo": "bar"},1,"foobar",true,null,[{"inner": "object"},1,null,[]]]')
result = deep_with_indifferent_access(test)
# => [{"foo"=>"bar"}, 1, "foobar", true, nil, [{"inner"=>"object"}, 1, nil, []]]

result[0][:foo]
# => "bar"

result[5][0][:inner]
# => "object"

note: the deep recursion implementation is probably bugged too 😅

[2k-joker]

That's what the NoMethodError rescue is for hehe. "I tried to help but your thing is weird so I'm leaving it as-is, enjoy"