Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logger): Fix reference to ruby default Logger constant #19

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix(logger): Fix reference to ruby default Logger constant #19

merged 1 commit into from
Jul 28, 2023

Conversation

2k-joker
Copy link
Collaborator

What

When no :event_logger object is configured, the call out to ruby default Logger constant was clashing with constant name of HTTPigeon Logger.

Why

Fix this so that users don't get unexpected/misleading error messages when they don't set the optional :event_logger config

@2k-joker 2k-joker merged commit ec99bd5 into main Jul 28, 2023
@2k-joker 2k-joker deleted the fix-bug-in-logger branch July 28, 2023 20:12
@github-actions github-actions bot mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@2k-joker