Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add customizable log redactor that can handle both Hash and String payload. Also add support for auto-generating request IDs #14

Merged
merged 5 commits into from
Jul 27, 2023

Conversation

2k-joker
Copy link
Collaborator

@2k-joker 2k-joker commented Jul 25, 2023

What

  • Add support for customizable logs redactor that can handle filtering of both Hashes and Strings
  • Add support for optionally auto-generating request IDs
  • Add support for specifying what string to use as replacement when redacting sensitive data

Why

  • These are useful features to have

Testing

  • Can test using dummyjson api
  • Can also test by installing a local version of the gem in core dailypay or other ruby-based app
    • Install the gem locally (bundle exec rake install:local)
    • Add the gem to your project Gemfile gem httpigeon, path: 'path/to/your/local/directory/httpigeon'
    • Run bundle install

2k-joker added 2 commits July 24, 2023 19:57
…ing payload. Also add support for auto-generating request IDs
@2k-joker 2k-joker changed the title Add support for logger redactor feat: Add customizable log redactor that can handle both Hash and String payload. Also add support for auto-generating request IDs Jul 25, 2023
README.md Show resolved Hide resolved
pcorliss
pcorliss previously approved these changes Jul 27, 2023
Copy link

@ShivamPatel17 ShivamPatel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool stuff!

@2k-joker 2k-joker merged commit c3efa0a into main Jul 27, 2023
@2k-joker 2k-joker deleted the add-support-for-logger-redactor branch July 27, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants