Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(httpigeon): [XAPI-1353] Gemify HTTPigeon library #1

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

2k-joker
Copy link
Collaborator

@2k-joker 2k-joker commented Jun 15, 2023

What

Translate HTTPigeon library from core into a ruby DailyPay private gem

Why

So that it's shareable between Rails based microservices like mogwai

Testing steps

  • Checkout this branch
  • Run $ bundle exec rake install:local
  • Checkout test-httpigeon-ruby branch in dailypay core and replace :path value to match your local path
  • Run $ bundle install
  • Open a rails console and play around with the gem

Related Links

@2k-joker 2k-joker force-pushed the xapi-1353-gemify-httpigeon-lib branch from 217c87e to a51645b Compare June 15, 2023 17:47
@2k-joker 2k-joker changed the title Xapi 1353 gemify httpigeon lib feat(httpigeon): [XAPI-1353] Gemify HTTPigeon library Jun 15, 2023
@2k-joker 2k-joker marked this pull request as ready for review June 15, 2023 18:07
@2k-joker 2k-joker requested a review from a team June 15, 2023 18:11
Gemfile.lock Outdated Show resolved Hide resolved
remzelg
remzelg previously approved these changes Jun 15, 2023
Copy link

@remzelg remzelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only did a quick review of the functional code, as I'm assuming it's pretty much the same as what we have in code atm. Gem contents and tests look good though.

Had one Q about the necessity of Gemfile.lock. I haven't seen that file show up in gems before

sig/httpigeon/ruby.rbs Outdated Show resolved Hide resolved
@2k-joker
Copy link
Collaborator Author

Only did a quick review of the functional code, as I'm assuming it's pretty much the same as what we have in code atm. Gem contents and tests look good though.

Had one Q about the necessity of Gemfile.lock. I haven't seen that file show up in gems before

@remzelg Did you try installing the gem locally? Did it work?

@2k-joker 2k-joker force-pushed the xapi-1353-gemify-httpigeon-lib branch from 9a917d6 to e8e9cc7 Compare June 15, 2023 18:51
@2k-joker 2k-joker merged commit ee89810 into main Jun 16, 2023
@2k-joker 2k-joker deleted the xapi-1353-gemify-httpigeon-lib branch June 16, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants