Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: implement DEV only logic as vite plugins #219

Closed
dai-shi opened this issue Dec 4, 2023 · 7 comments
Closed

Refactor: implement DEV only logic as vite plugins #219

dai-shi opened this issue Dec 4, 2023 · 7 comments

Comments

@dai-shi
Copy link
Owner

dai-shi commented Dec 4, 2023

After #218, I think we can move some code (including Worker) into new vite plugins.

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 28, 2023

@Aslemammad I think you can try this after #324.
What I have in mind is creating many small plugins (like what we do now) and one plugin that calls all of them, that is for easier use.

@Aslemammad
Copy link
Contributor

Yep! We can do that.

@Aslemammad
Copy link
Contributor

I'll get to all of these issues soon, just a bit busy on my side. Thanks.

@dai-shi
Copy link
Owner Author

dai-shi commented Jan 12, 2024

For the next release, #323 and #344 are more important.
Furthermore, I might be refactoring something soon, and maybe this issue can be delayed. (at the same time, I would like to know the approach, so giving a try/draft would be good.)

@dai-shi
Copy link
Owner Author

dai-shi commented Jan 15, 2024

After some investigations, it feels like eliminating worker is possible if we somehow support CommonJS #110 without externalinsing or commonjs-transpiling selectively, and transpile all commonjs packages including React libs.

@dai-shi
Copy link
Owner Author

dai-shi commented Feb 2, 2024

#445 goes the other way around. If it goes well, we will likely keep worker for quite a while. So, we should move this issue forward with the worker. It means this issue is ready to tackle.

@dai-shi
Copy link
Owner Author

dai-shi commented Aug 17, 2024

Let's give this up for now. Our middleware architecture goes against to it. Let's revisit it when we understand the requirement better.

@dai-shi dai-shi closed this as completed Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants