-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support hot reload for server components #113
Comments
Fast refresh should work if you only modify client components. If a file is used both by client components and server components, it will full reload. |
Ah cool. It would be great to support fast refresh of server components then! This is possible in Next.js. |
Yeah, if it's technically possible, we could do it. As Vite (probably) supports only fast refresh of client components, to support that of server components, Waku would need its own mechanism... |
Yep. I'm hoping vite allows you to extend the websocket messages so that it could say something like |
@dai-shi I try to find the references about RSC fast refresh, but I could do it just in Next.js. It seems like that Vercel made HotReloaderWebpack module to fast-refresh a various of changes such as What I make vite rsc fast-refresh plugin is a bit challenge, but I would like to invest it |
Yeah, it will be challenging. We need to detect the server component changes and then do RSC refetch. |
this has a priority after v0.19.0. |
i was investigating but It's a bit hard for me to solve this issue cause i don't have enough knowledge about the vite bundler. |
Please feel free. We are all new to this stuff. You will learn something trying this, even if you don't reach the final solution. Challenging is good. |
As it seems there is a high demand on this #404, I will work on this with priority. |
I will call it "hot reload", because what I will do is not React Fast Refresh, nor HMR. |
Unless I'm mistaken
waku dev
only supports full-page reload with HMR right now, could it support react fast refresh?The text was updated successfully, but these errors were encountered: