Ssr doesn't work if use getContext in entries.ts 's defineRouter/getComponent

[EasonYou]

What's the issue

I use ssr with routes and getContext

As the code show, it doesn't work if use getContext in defineRouter/getComponent.

https://github.com/EasonYou/waku-example/blob/71308df89396c7fa6b5c9ce54ff46d8fafcdf7aa/src/entries.ts#L1-L21

What do I find

The error tells that ctx was empty, it cause by the getComponent so that waku can't get element by getSsrConfig because of the component import error. Then the ssr will not work. But no error on the client side, just like a csr app.

waku/src/router/server.ts

Lines 155 to 171 in 5af1c34

	const getSsrConfig: GetSsrConfig = async (pathStr) => {
	const url = new URL(pathStr, "http://localhost");
	// We need to keep the logic in sync with waku/router/client
	// FIXME We should probably create a common function
	const pathItems = url.pathname.split("/").filter(Boolean);
	const rscId = pathItems.join("/") || "index";
	try {
	await getComponent(rscId);
	} catch (e) {
	// FIXME Is there a better way to check if the path exists?
	return null;
	}
	return { element: [SSR_PREFIX + url.pathname, { search: url.search }] };
	};
	return { getEntry, getBuildConfig, getSsrConfig };
	}

I don't know if it is a purposeful design that user can't use getSsrConfig or it is a bug.

[dai-shi]

Thanks for reporting!
Does it fix or change something if you comment out L162 in src/router/server.ts?

[EasonYou]

No, if you commont out L162, all the ssrConfig will be got in the ssr middleware(see the code below L99). It cause that all the request wiil be handled as a ssr page.
I have time to try to fix it, maybe I can create a pr later.

waku/src/lib/middleware/ssr.ts

Lines 98 to 104 in 5af1c34

	if (req.url && !req.headers["x-waku-ssr-mode"]) {
	const ssrConfig = getSsrConfig && (await getSsrConfig(req.url));
	if (ssrConfig) {
	const rscServer = new URL(
	config.framework.ssr.rscServer,
	"http://" + req.headers.host
	);

[dai-shi]

Oh, yeah, that's right..

I think we should avoid using getComponent in getSsrConfig.

[EasonYou]

Index component is default as the routes' entry, but I find that if I visit index path, it will render the index components as child.

[dai-shi]

Oh, I wasn't aware that could happen. (So, it's a bug...)

Right, I think how we handle index is a bit weird compared to community standard.
I would like to fix/improve the file name convention and support [slug].tsx too.

Let's tackle them separately.