Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support completion for new git switch and git restore commands #691

Closed
kidonng opened this issue Aug 18, 2019 · 9 comments · Fixed by #702
Closed

Support completion for new git switch and git restore commands #691

kidonng opened this issue Aug 18, 2019 · 9 comments · Fixed by #702

Comments

@kidonng
Copy link

kidonng commented Aug 18, 2019

Git 2.23 brings some new features which include two new commands: git switch and git restore, which are meant to eventually provide a better interface for git checkout.

https://github.blog/2019-08-16-highlights-from-git-2-23/#experimental-alternatives-for-git-checkout

@rkeithhill
Copy link
Collaborator

Saw that yesterday. These are still experimental and the blog post does mention that these could change (names, parameters, etc) before shipping in final form. I'd be inclined to wait for the commands to be finalized before adding support for them in posh-git. But maybe @dahlbyk has a different take?

@pinkfloydx33
Copy link

This feature was automatically enabled for me the last time I updated git. I don't have any experimental flags enabled or anything like that, so I think its mainstream at this point.

I've updated my local copy of the module to support this command, will you take a PR for the update?

@kidonng
Copy link
Author

kidonng commented Sep 10, 2019

@pinkfloydx33 Just show your fantastic work to the world☺️

@dahlbyk
Copy link
Owner

dahlbyk commented Sep 11, 2019

will you take a PR for the update?

Yes!

@crackedmind
Copy link

Saw that yesterday. These are still experimental and the blog post does mention that these could change (names, parameters, etc) before shipping in final form. I'd be inclined to wait for the commands to be finalized before adding support for them in posh-git. But maybe @dahlbyk has a different take?

I don't know why github blog said experimental about this feature. Because no mentions about this in official changelog. It's look stable
https://github.com/git/git/blob/master/Documentation/RelNotes/2.23.0.txt#L61

@rkeithhill
Copy link
Collaborator

@pinkfloydx33 Can you take a look at my PR (#702) and see how it compares to the changes you made to add support for these two commands.

@Himura2la
Copy link

Himura2la commented Apr 14, 2020

How soon should it be available in PowerShell Gallery? Two extremely often-used commands are not live in half a year after implementation and in a month after release, is it Really OK? I see it's beta, but the current stable release without switch and restore is probably less usable than beta

@rkeithhill
Copy link
Collaborator

The beta, which supports these two sub-commands, is in the PowerShell Gallery.

https://www.powershellgallery.com/packages/posh-git/1.0.0-beta4

@Himura2la
Copy link

@rkeithhill thank you, I did not notice it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants