Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF normalization disabled in .gitattributes #334

Closed
rkeithhill opened this issue Dec 30, 2016 · 2 comments · Fixed by #336
Closed

LF normalization disabled in .gitattributes #334

rkeithhill opened this issue Dec 30, 2016 · 2 comments · Fixed by #336

Comments

@rkeithhill
Copy link
Collaborator

I see this in .gitattributes:

# Disable LF normalization for all files
* -text

Why do we do this? When I git clone the repo on Linux and test/edit files, the line endings are screwed up in VI.

@dahlbyk
Copy link
Owner

dahlbyk commented Dec 30, 2016

When I git clone the repo on Linux and test/edit files, the line endings are screwed up in VI.

What do you mean by "line endings are screwed up in VI"? I would expect it to detect CRLF files without issue.

Why do we do this?

In short, because I didn't want to deal with a commit to normalize line endings in the repo (merge conflicts for every open PR). That said, I just stumbled on merge.renormalize (which has existed since 2010?!) that should help mitigate that issue. I wonder if GitHub supports that by default?

@rkeithhill
Copy link
Collaborator Author

All of the source files show ^M (carriage return) in VI on Ubuntu. Normally, the repo would clone down on Linux with just LF for new lines. Not a huge deal. Was just wondering if it would be worth changing this for an eventual 1.0.0 release as I (and hopefully others) edit & test the module directly on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants