display new bulk action statuses in UI #24409
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @jamiedemaria and the rest of your teammates on |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit fe62f0f. |
jamiedemaria
force-pushed
the
jamie/bulk-action-status-fe
branch
from
dd90824 to
6ccf131
Compare
jamiedemaria
force-pushed
the
jamie/fou-385-expand-bulkactionstatus-to-encompass-completed-success-and
branch
from
c0f3355 to
ea8ea41
Compare
jamiedemaria
force-pushed
the
jamie/bulk-action-status-fe
branch
from
6ccf131 to
55bc124
Compare
jamiedemaria
force-pushed
the
jamie/fou-385-expand-bulkactionstatus-to-encompass-completed-success-and
branch
from
ea8ea41 to
2a8e135
Compare
jamiedemaria
force-pushed
the
jamie/bulk-action-status-fe
branch
from
55bc124 to
cf3cda5
Compare
js_modules/dagster-ui/packages/ui-core/src/instance/backfill/BackfillStatusTagForPage.tsx
Outdated
Show resolved
Hide resolved
jamiedemaria
force-pushed
the
jamie/bulk-action-status-fe
branch
from
cf3cda5 to
053a692
Compare
jamiedemaria
force-pushed
the
jamie/fou-385-expand-bulkactionstatus-to-encompass-completed-success-and
branch
from
2a8e135 to
0923a4b
Compare
jamiedemaria
force-pushed
the
jamie/bulk-action-status-fe
branch
from
053a692 to
836261e
Compare
| @@ -42,6 +42,10 @@ const labelForBackfillStatus = (key: BulkActionStatus) => { | |||
| return 'Failed'; | |||
| case BulkActionStatus.REQUESTED: | |||
| return 'In progress'; | |||
| case BulkActionStatus.COMPLETED_SUCCESS: | |||
There was a problem hiding this comment.
I matched the tense of the existing labels for this PR, but the runs page uses success and failure instead of succeeded and failed. should i align them?
cc @salazarm
There was a problem hiding this comment.
maybe not so important for this PR, but we should just keep it in mind to make sure the runs feed uses consistent terminology
There was a problem hiding this comment.
The tenses within DagsterRunStatus and step events are also annoyingly inconsistent with each other. E.g. STARTED vs. FAILURE. However I think we use SUCCESS pretty consistently throughout the product, so I support using that instead of SUCCEEDED.
jamiedemaria
force-pushed
the
jamie/fou-385-expand-bulkactionstatus-to-encompass-completed-success-and
branch
from
0923a4b to
f097359
Compare
jamiedemaria
force-pushed
the
jamie/bulk-action-status-fe
branch
from
836261e to
fff1c4e
Compare
jamiedemaria
force-pushed
the
jamie/bulk-action-status-fe
branch
from
fff1c4e to
3e5d992
Compare
jamiedemaria
force-pushed
the
jamie/fou-385-expand-bulkactionstatus-to-encompass-completed-success-and
branch
from
924c8a3 to
8322a44
Compare
jamiedemaria
force-pushed
the
jamie/bulk-action-status-fe
branch
from
3e5d992 to
5bd30fe
Compare
jamiedemaria
force-pushed
the
jamie/fou-385-expand-bulkactionstatus-to-encompass-completed-success-and
branch
from
8322a44 to
8f9343e
Compare
jamiedemaria
force-pushed
the
jamie/bulk-action-status-fe
branch
from
5bd30fe to
617f667
Compare
jamiedemaria
force-pushed
the
jamie/fou-385-expand-bulkactionstatus-to-encompass-completed-success-and
branch
from
8f9343e to
7b447bb
Compare
jamiedemaria
force-pushed
the
jamie/bulk-action-status-fe
branch
from
617f667 to
fe62f0f
Compare
jamiedemaria
merged commit 26d0664
into
jamie/fou-385-expand-bulkactionstatus-to-encompass-completed-success-and
Summary & Motivation
Updates the FE to display the
COMPLETED_SUCCESSandCOMPLETED_FAILEDstatuses in the downstream PRHow I Tested These Changes
Backfill run after updating the UI shows
Succeededstatus. Backfill run before the UI update is stillCompleted. Note that we changed the language toSuccessinstead ofSucceededso this screenshot is slightly out of dateChangelog
Insert changelog entry or "NOCHANGELOG" here.
NEW(added new feature or capability)BUGFIX(fixed a bug)DOCS(added or updated documentation)