-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed path normalize on Windows, Alternative file extension, can.view.attr #32
Conversation
Added extension mapping, if you use another view extension as ".mustache", eg. ".mst". Just added "extension" parameter to the options. If can.view.attr is used, it wasn´t take into account. Added an options parameter to maintain used view attrs. Signed-off-by: srasp <[email protected]>
Awesome thank you! Two things: The build failed with a JSHint error (the variable Could you also add the documentation for the |
Documentation updated
As you recommended I changed the variable in compile.js and added the parameters to the documentation as well as in the command line at can-compile. |
@srasp It looks like the automated tests have failed again. You can click the details link to the right of the message that says "The Travis CI build failed" to see what's going on. You can actually run these tests yourself before pushing your code, as well. Have you tried running the tests on your own machine? If you're not familiar with the process, this is how to get it working:
If the tests run without any errors and you're cleaning up anything JSHint says to fix, the Travis CI builder won't balk at your awesome commits. |
That's a weird error though. I'll check what's going on. |
Updated test, because normalizer method did not work on Windows, Added test for alternative file extension (.mst)
Sorry guys, now it should work. I had to check if the new option |
No need to apologize. Thank you for your work. |
Awesome, thank you! |
Fixed path normalize on Windows, Alternative file extension, can.view.attr
Released as version 0.8.0. Thanks again! |
Added extension mapping, if you use another view extension as ".mustache", eg. ".mst". Just added "extension" parameter to the options.
If can.view.attr is used, it wasn´t take into account. Added an options parameter to maintain used view attrs.
Signed-off-by: srasp [email protected]