Conditional registrations

[TheHunter]

ContainerTest.txt

Hi everyone,
I'm finding a problem using a conditional registrations, when I use at the end one registration without condition, the previous registrations (with condition) don't work in one specific case, when registrations with condition have a lower scope than the default registration (without condition), and it seems that the default one have the precedence, ignoring previous conditional registrations.

Take a look to this example:

public class ServiceConsumerA(IService service)
{
    public IService Service { get; private set; } = service;
}

public class ServiceConsumerB(IService service)
{
    public IService Service { get; private set; } = service;
}

public class MyServiceA : IService { }

public class MyServiceB : IService { }

public interface IService { }

[Fact]
public void TestWithDefaultScopeToSingleton()
{
    var container = new Container();

    // it works even for Reuse.Singleton
    var scopeA = Reuse.Transient;
    var scopeB = Reuse.Singleton;

    container.Register(typeof(IService), typeof(MyServiceA),
        reuse: scopeA
        , setup: Setup.With(condition: request => request.DirectParent.ServiceType == typeof(ServiceConsumerA))
    );

    // the intention is having a default resolution if previous conditions aren't satisfied !!
    container.Register(typeof(IService), typeof(MyServiceB),
        reuse: scopeB
    );

    container.Register(typeof(ServiceConsumerA));
    container.Register(typeof(ServiceConsumerB));

    var consumerA = container.Resolve<ServiceConsumerA>();
    var consumerB = container.Resolve<ServiceConsumerB>();

    Assert.NotNull(consumerA);
    Assert.NotNull(consumerB);

    // here is the mismatch from consumerA.Service type !!.
    Assert.Equal(typeof(MyServiceA), consumerA.Service.GetType());
    Assert.Equal(typeof(MyServiceB), consumerB.Service.GetType());
}

If you try it only changing the scope of scopeA in Singleton it works.

[Fact]
public void TestWithIdenticalScopes()
{
    var container = new Container();

    // it works even for Reuse.Singleton
    var scopeA = Reuse.Transient;
    var scopeB = Reuse.Transient;

    container.Register(typeof(IService), typeof(MyServiceA),
        reuse: scopeA
        , setup: Setup.With(condition: request => request.DirectParent.ServiceType == typeof(ServiceConsumerA))
    );

    // the intention is having a default resolution if previous conditions aren't satisfied !!
    container.Register(typeof(IService), typeof(MyServiceB),
        reuse: scopeB
    );

    container.Register(typeof(ServiceConsumerA));
    container.Register(typeof(ServiceConsumerB));

    var consumerA = container.Resolve<ServiceConsumerA>();
    var consumerB = container.Resolve<ServiceConsumerB>();

    Assert.NotNull(consumerA);
    Assert.NotNull(consumerB);

    // those asserts work, so types match !
    Assert.Equal(typeof(MyServiceA), consumerA.Service.GetType());
    Assert.Equal(typeof(MyServiceB), consumerB.Service.GetType());
}

Probably something is wrong in the example, mainly in the registration of default registration (without condition).

The complete unit test is attached in this post.

Any help will be appreciated :).

Thanks

[dadhi]

@TheHunter Thanks for the tests, I will look after I'm done with the current thing.

[TheHunter]

Hi @dadhi,
thank you for your help.