This repository has been archived by the owner on Aug 22, 2023. It is now read-only.
Refactor for Pelican 4 + inline minification #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For at least all versions under 0.9.5 of csscompressor, there is a faulty compression on the url() func of css rules; spaces are wrongly removed, thus destroying the meaning of any embedded svg file. See sprymix/csscompressor#9
jsmin is used for JavaScript minification; csscompressor is used as for css files
- simplify maintenance process by removing references to specific versions of dependencies (See setup.cfg instead) - Add jsmin dep - Add script & style related minification
Merged
dArignac
approved these changes
Feb 19, 2022
There was a problem hiding this comment.
Hi @ysard,
thanks a lot for the PR - great enhancement!
I'll merge it as well as your other one (thanks for that as well!).
Afterwards I have to adjust the release approach, as the repo is 8 years old. A release of 0.2.0 will follow soon.
|
Hi, thank you for acceptance and for the support of this old (but always useful!) project! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, in this PR I purpose some changes and refactoring to make this plugin compatible with Pelican 4 (Python3).
I also added the possibility to minify the css and the JS included in the HTML pages.
In short:
I am open to any proposal, it would be welcome to have an update on pypi following this.
As well as an addition to the new official listing https://github.com/pelican-plugins/ via a PR on https://github.com/getpelican/pelican-plugins
Thanks for reading.