Skip to content
This repository has been archived by the owner on Jun 16, 2023. It is now read-only.

7316-356 has multiple extent of tumor resection #366

Closed
jharenza opened this issue Jun 21, 2022 · 6 comments
Closed

7316-356 has multiple extent of tumor resection #366

jharenza opened this issue Jun 21, 2022 · 6 comments
Assignees
Labels

Comments

@jharenza
Copy link
Collaborator

What data file(s) does this issue pertain to?

histologies.tsv

What release are you using?

v11 OPC, v22 OpenPBTA

Put your question or report your issue here.

7316-356 went from having Partial resection in v21 OpenPBTA to Partial resection;Gross/Near total resection in v22. It looks like this is stemming from a concatenation of Diagnosis + 3 month update records, the latter of which @youngnm tells me should be removed from the data warehouse and CBTN all.

cc @youngnm @nicholasvk

@jharenza
Copy link
Collaborator Author

jharenza commented Jul 8, 2022

This was manually updated in the V11 histologies-base.tsv file with d3b-center/OpenPedCan-analysis#188, but can we confirm this was updated in the data warehouse/CBTN all shiny app @youngnm @nicholasvk ?

@jharenza
Copy link
Collaborator Author

@youngnm can you check this one as well?

@youngnm
Copy link

youngnm commented Jul 29, 2022

In the short term, is it possible for you to filter out the 3 month update records on your end? I'll raise this as a discussion item with the larger team because it's a major change to CBTN-All. Not sure what the timeline looks like yet.

@jharenza
Copy link
Collaborator Author

I realized I never responded @youngnm - I have already taken care of this manually!

@chinwallaa chinwallaa added v12 and removed v11 labels Aug 29, 2022
@jharenza
Copy link
Collaborator Author

@nicholasvk - can you update this sample in the D3b warehouse?

@jharenza
Copy link
Collaborator Author

Develop a coding rule to prioritize one over the other (i.e. - use the 3 month update value because its the latest or some other rule)

Some of these are tricky and have to be done on a sample to sample basis. I had confirmed all of these with Jenn before any updates and for this sample, the coding logic here should be: For 7316-356 --> Partial resection. We do not want to use a 3 month update for tumor resection because the genomic data is for the initial visit, and at that visit, there was only partial resection. Can we add this upstream on your end if we are going to maintain 3 month updates?

@d3b-center d3b-center deleted a comment from nicholasvk Sep 7, 2022
@ewafula ewafula closed this as completed Nov 17, 2022
@ewafula ewafula mentioned this issue Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants