fix: fix deployment for storybook 7 #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes D2IQ-97583
|
Uffizzi Preview |
nataliepina
approved these changes
Jun 12, 2023
|
🎉 This PR is included in version 14.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
With this change, we should make sure to update all branches with the latest main branch prior to merging as we do not execute tests anymore before publishing after a merge. These are two separate actions now, so the tests could fail but we still publish. (We do not execute tests in any Is anyone against me enabling that checkbox?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes D2IQ-97583
Description
This removes storybook deployer for using a more native action.
Which issue(s) does this PR relate to?
Testing
Not sure we can until it is merged.
Trade-offs
We no longer have a script to do this manually. Not sure we would want to anyways.
Checklist